konklone / congress-android

Congress for Android, an app for tracking Congress.
https://play.google.com/store/apps/details?id=com.sunlightlabs.android.congress
Other
158 stars 43 forks source link

Delete local libs and replace with gradle implementations #757

Closed TacoTheDank closed 5 years ago

TacoTheDank commented 5 years ago
konklone commented 5 years ago

Thank you! These generally look good, though I'll test them on my phone and emulators before merging. Did you test these changes on a device or emulator yourself?

TacoTheDank commented 5 years ago

No, because I didn't think there was a need to. No actual code was changed, so I think everything should build perfectly fine.

(Also, you should really take some time to update those libraries lmao)

konklone commented 5 years ago

No, because I didn't think there was a need to. No actual code was changed, so I think everything should build perfectly fine.

That's usually how it goes, though the commonsware WakefulIntent stuff has been brittle and buggy in the past (and I still get stuck wakelock reports sometimes).

(Also, you should really take some time to update those libraries lmao)

This is a free app maintained by one person in their spare time. :) Updates come in bursts!

TacoTheDank commented 5 years ago

This is a free app maintained by one person in their spare time. :) Updates come in bursts!

Lol I get it. Honestly I'd do it myself if I had the proper knowledge.

TacoTheDank commented 5 years ago

@konklone Will this be merged? I'd like to see something done lol.

konklone commented 5 years ago

Thanks for the poke. I've been very heads-down the last couple months, as I'm actually joining Congress as a staffer (through a fellowship: https://www.techcongress.io/fellows/). I just wrapped up an important milestone, so I'll try to get this merged this weekend.

TacoTheDank commented 5 years ago

Sounds awesome!