search

konklone / json

A free, in-browser JSON to CSV converter.
https://konklone.io/json/
Other
753 stars 211 forks source link

An option to select a separator (comma, tab or semicolon) is added. #229

Closed maijs closed 4 years ago

maijs commented 5 years ago

This change adds an option to select a separator for the CSV:

image

Steps to review:

  1. Paste JSON into the textarea.
  2. Click on Show the raw data and see that comma is used as a separator.
  3. Change the separator to Tab, click on Show the raw data and see that tab is used as a separator.
  4. Change the separator to Semicolon, click on Download the entire CSV and see that in the downloaded file semicolon is used as a separator.
maijs commented 4 years ago

@konklone Ahem, may I ask your review on this RP? It's quite small, but useful as tab is a popular delimiter for CSV files.

konklone commented 4 years ago

Oh man, thank you for the nudge - and for the PR. This looks simple, well-written, and helpful. I would prefer the separator dropdown be placed to the left of the "Since the conversion..." text rather than above it, for compactness, but that's not a blocker.

konklone commented 4 years ago

@maijs Also, let me know if you have a Twitter account, so I can cite your contribution in a tweet.