Closed justinribeiro closed 10 years ago
Looks good to me, and tests pass! :smile_cat: Thanks for doing this. I gave you, along with @jonnybarnes and @mathiasbynens, write access to the repo from now on. I'd still prefer PRs, but this way you can do them on a branch instead of in a fork.
:+1:
After your recent regex commit @konklone I started thinking about other domain name cases that may need to be tested. I was using Google's Domain Test service (see https://github.com/google/domaintest) and international domain names seem like a good set of test cases to add. The two domains included are part of that suites gTLD list.
The current build works with the A-Label ASCII representation without issue:
The only issue I've run into when running the cases with faucet is I sometimes get a gethostbyname failure (which I'm not sure if it's my flaky connection or something else). Thoughts/feedback appreciated.