search

konkodi210 / sampratistaana

MIT License
3 stars 0 forks source link

Pusthaka daasthaanu screen related comments #33

Closed mohankmithur closed 3 years ago

mohankmithur commented 3 years ago

a. Same as point #7 – deleting works, add/modify does not work b. May be a standard discount can be mentioned for each book added c. For re-printed books, I think we need add as separate new item (with some value appended like Reprint_2020) while adding to stock, not modify the existing one I guess. And, that makes complete sense.

konkodi210 commented 3 years ago

Point a: It does work. see the comments in issue #17 . If you still cannot do, please talk to @murarisharma31. Also there is automated test script BookInventoryManagementTest.java

konkodi210 commented 3 years ago

On point c, cant we update same items. This is reason why I gave edit. Adding new item, upon re-print will show new entry in book sale list. I think it will be messy

murarisharma31 commented 3 years ago

@mohankmithur , Can you please attach screenshots of the issue, may be helpful to avoid multiple calls. @konkodi210

mohankmithur commented 3 years ago

a is addressed through some other ticket.

b is invalid. Discount can be provided in pustaka maaraata screen

c is invalid. Reprinted books (if they have different pricing) are to be entered as new book. Else can be added to existing stock. This provision is already available.