search

konmik / nucleus

Nucleus is an Android library, which utilizes the Model-View-Presenter pattern to properly connect background tasks with visual parts of an application.
MIT License
1.97k stars 253 forks source link

Repro for #147 #148

Closed TWiStErRob closed 7 years ago

TWiStErRob commented 7 years ago

First I started building a separate project, but then I realized you had examples already. So I just upgraded your repo instead to the latest build tools and SDK, enabled ProGuard for example's release builds and then manually added a dependency higher than what Nucleus is built with to repro #147.

(Note: the upgrade is not fully complete, there are some warnings as build (Jack, Android deprecations and Gradle deprecations), but everything seems to work for now.)

konmik commented 7 years ago

I couldn't merge it because of irrelevant modifications, but thanks for the reproducible example anyway!

TWiStErRob commented 7 years ago

I can drop last commit, or the mods that you think are irrelevant, just comment which ones.

TWiStErRob commented 7 years ago

Ah, I see, proguard :)

konmik commented 7 years ago

There were also gradle script changes, okhttp, apt, and the PR didn't solve the problem :) I needed it to be solved for both - master and rx2 branches.