konnected-io / konnected-esphome

ESPHome firmware configuration and recipes for Konnected devices
Other
49 stars 31 forks source link

Toggle call should execute toggle command after pre-close warning #40

Closed heythisisnate closed 3 months ago

heythisisnate commented 3 months ago

https://github.com/konnected-io/konnected-esphome/blob/a74b08309bdf73146498f7595afbd34f82a1008a/components/secplus_gdo/cover/gdo_door.cpp#L91-L97

Apparently, some garage openers do not have a discrete open and close command and only will respond to toggle. As implemented above, the garage door will not close on these openers because the toggle call is being translated into a close command after the pre-close warning.

Ideally, the toggle command should be called after the pre-close warning when initiated by a toggle call.