search

konnected-io / konnected-security

Konnected connects wired sensors and switches to SmartThings, Home Assistant, Hubitat and OpenHAB
https://konnected.io
Apache License 2.0
416 stars 322 forks source link

Add support for typical key switch with relay #88

Closed tailg8nj closed 5 years ago

tailg8nj commented 5 years ago

So this is my first foray into Konnected and SmartThings so please bear with me if the code needs tests or the tiles are ugly.

This device handler successfully controls my Vista 20P key switch. I set my system up similar to Dave Parsons in https://help.konnected.io/support/discussions/topics/32000001630.

This handler can handle both a "push" and a "hold" of the button to produce two different momentary delays, in my case 1000ms and 3000ms.

Please let me know what I need to do to get this acceptable

heythisisnate commented 5 years ago

Thanks for the contribution! This is great. I didn't know that the key switch on the Vista had two different functions based on timing. Neat!

The code looks pretty good ... but why the icon of the remote control? Is the 1s/3s keyswitch a standard thing for all the Vista panels? Maybe it makes more sense to make it specific to that and name the buttons "Arm Stay" and "Arm Away" instead. What do you think?

tailg8nj commented 5 years ago

The 1s/3s is standard at least across Vista 15 & 20: http://library.ademconet.com/MWT/fs2/9/1005.pdf.

I've made the updates requested.

tailg8nj commented 5 years ago

Now that I've specialized it to be Vista specific, I'm wondering if I should further customize it to use the proper SmartThings Button state values, and also modify the tiles to show correctly with the alarm status. I would need access to other pin states. is that possible via an API call?

tailg8nj commented 5 years ago

Closing in favor of https://github.com/tailg8nj/konnected-vista-integrations