search

konnected-io / noonlight-hass

HomeAssistant integration for Noonlight
43 stars 9 forks source link

Using Deprecated hass.helpers.dispatcher #18

Open Snuffy2 opened 5 months ago

Snuffy2 commented 5 months ago

Not sure if this is still being maintained, but this warning began with 2024.5. If not addressed by 2024.11, it looks like the integration will stop working.

@snicker I just noticed that you put out the last release. Any chance this could be updated? 

2024-05-05 11:07:48.165 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration noonlight which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2024-05-05 11:08:43.978 WARNING (MainThread) [homeassistant.helpers.frame] Detected that custom integration 'noonlight' accesses hass.helpers.dispatcher. This is deprecated and will stop working in Home Assistant 2024.11, it should be updated to import functions used from dispatcher directly at custom_components/noonlight/switch.py, line 36: hass.helpers.dispatcher.async_dispatcher_connect(, please report it to the author of the 'noonlight' custom integration
snicker commented 2 months ago

hey @Snuffy2 - likely going to have a chance to work on this in the next week here, would you be willing to discuss integrating changes from your fork into the main integration?

Snuffy2 commented 2 months ago

Absolutely, I'd be happy to. I have a working version that's been updated and using config flow. Uses v1 of the API and supports address or Lat/Long. Still needs some more testing and some other eyes to review (and I'm sure some fixes, optimization and code cleanup).

I'll get it into a PR into this Repo in the next couple of days.