konpyutaika / nifikop

The NiFiKop NiFi Kubernetes operator makes it easy to run Apache NiFi on Kubernetes. Apache NiFI is a free, open-source solution that support powerful and scalable directed graphs of data routing, transformation, and system mediation logic.
https://konpyutaika.github.io/nifikop/
Apache License 2.0
135 stars 46 forks source link

Pod health in ArgoCD stuck in Progressing #145

Open mh013370 opened 2 years ago

mh013370 commented 2 years ago

Bug Report

ArgoCD will never progress the health of Pod resources beyond Progressing when a Pod's restart policy is either never or onFailure. This is intentional as they assume Pods in this case are always ephemeral.

https://github.com/argoproj/argo-cd/issues/7259 https://github.com/argoproj/argo-cd/issues/7182

There's not currently a workaround and several other operators which behave this way are affected.

Environment

Possible Solution

Evaluate whether it's possible to change the pod restart policy and still have the operator function properly.

cannonpalms commented 2 years ago

Evaluate whether it's possible to change the pod restart policy and still have the operator function properly.

This is the ticket, imo. It would also unlock more extensive usage of sidecar containers.

rrs-celonis commented 6 months ago

This is affecting arangodb operator as well, would appreciate a fix for it, thanks!

mh013370 commented 6 months ago

This would require a change in ArgoCD or a custom application health Lua snippet for the NiFi pods: https://argo-cd.readthedocs.io/en/stable/operator-manual/health/

Liammarwood commented 3 months ago

Has anyone got a custom heath lua snippet for this?