search

konpyutaika / nifikop

The NiFiKop NiFi Kubernetes operator makes it easy to run Apache NiFi on Kubernetes. Apache NiFI is a free, open-source solution that support powerful and scalable directed graphs of data routing, transformation, and system mediation logic.
https://konpyutaika.github.io/nifikop/
Apache License 2.0
126 stars 44 forks source link

Make NiFi pod readiness and liveness checks configurable #220

Closed mh013370 closed 1 year ago

mh013370 commented 1 year ago
Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #219
License Apache 2.0

What's in this PR?

This makes the NiFi Pod readiness and liveness checks configurable. These are new optional fields, so if they aren't overridden, then the current defaults are still used as before.

I've added this to both v1 and v1alpha1 API versions.

Why?

See #219 for details.

Checklist

mh013370 commented 1 year ago

The documentation must reflect this change.

Good call! Will update the docs.

mh013370 commented 1 year ago

If I'm not mistaken, correct me @erdrix if I'm wrong, but you should not update the v1alpha1 CRD, only the v1. We do not update v1alpha1 anymore for resource in v1.

I'd think if anything, we'd only change the v1alpha1 version to introduce the change until we consider it stable and then at a later time add it to v1. However, with some changes (e.g. new optional fields) the risk is low so I went ahead and added it to both API versions.

I'm happy to change this, but that's why I added it to both.

... Or are you suggesting adding a v2alpha1?

juldrixx commented 1 year ago

I confirmed it with @erdrix (a while ago, but forget 😂).

We will now work on v1 resources and won't update v1alpha1 anymore. It's how it works with resources in K8S. And maybe we will, one day, move to a v2.

Of course, for new resource or resource without v1 will still work on v1alpha1

mh013370 commented 1 year ago

I confirmed it with @erdrix (a while ago, but forget 😂).

We will now work on v1 resources and won't update v1alpha1 anymore. It's how it works with resources in K8S. And maybe we will, one day, move to a v2.

Of course, for new resource or resource without v1 will still work on v1alpha1

Okay, i will remove the v1alpha1 changes!

mh013370 commented 1 year ago

I've removed the v1alpha1 changes. This PR should be good to go!

mh013370 commented 1 year ago

@juldrixx Do you see any more changes needed on this PR?