konpyutaika / nifikop

The NiFiKop NiFi Kubernetes operator makes it easy to run Apache NiFi on Kubernetes. Apache NiFI is a free, open-source solution that support powerful and scalable directed graphs of data routing, transformation, and system mediation logic.
https://konpyutaika.github.io/nifikop/
Apache License 2.0
125 stars 42 forks source link

Upgraded nifikop to go 1.20, and upgraded all dependencies #244

Closed r65535 closed 1 year ago

r65535 commented 1 year ago
Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets
License Apache 2.0

What's in this PR?

Why?

To keep things up to date!

Additional context

sigs.k8s.io/controller-runtime/pkg/envtest/printer has been depreciated so I removed our single dependency on it

It looks like upgrading the controller-gen package amended all the CRDs too - I can revert this if we don't want to touch them?

Checklist

To Do

mh013370 commented 1 year ago

We will need a new build image pushed to fix the build here:

Starting container ghcr.io/konpyutaika/docker-images/nifikop-build:1.20
  image cache not found on this host, downloading ghcr.io/konpyutaika/docker-images/nifikop-build:1.20

  Error pulling image ghcr.io/konpyutaika/docker-images/nifikop-build:1.20: Error response from daemon: manifest unknown... retrying
  image cache not found on this host, downloading ghcr.io/konpyutaika/docker-images/nifikop-build:1.20

I raised a proposal to relocate the build image into its own repo so that we can manage it separately from nifikop itself:

https://konpytika.slack.com/archives/C035X6KP684/p1679311915366969

Either that or we add CI jobs to auto-push the build image to avoid it being a hurdle in the future and requiring manual intervention.

mh013370 commented 1 year ago

Pushed nifikop-build:1.20:

https://github.com/orgs/konpyutaika/packages/container/docker-images%2Fnifikop-build/81214864?tag=1.20

mh013370 commented 1 year ago

Once the unit tests pass i can merge 😄