Closed r65535 closed 1 year ago
We will need a new build image pushed to fix the build here:
Starting container ghcr.io/konpyutaika/docker-images/nifikop-build:1.20
image cache not found on this host, downloading ghcr.io/konpyutaika/docker-images/nifikop-build:1.20
Error pulling image ghcr.io/konpyutaika/docker-images/nifikop-build:1.20: Error response from daemon: manifest unknown... retrying
image cache not found on this host, downloading ghcr.io/konpyutaika/docker-images/nifikop-build:1.20
I raised a proposal to relocate the build image into its own repo so that we can manage it separately from nifikop itself:
https://konpytika.slack.com/archives/C035X6KP684/p1679311915366969
Either that or we add CI jobs to auto-push the build image to avoid it being a hurdle in the future and requiring manual intervention.
Pushed nifikop-build:1.20
:
Once the unit tests pass i can merge 😄
What's in this PR?
Why?
To keep things up to date!
Additional context
sigs.k8s.io/controller-runtime/pkg/envtest/printer has been depreciated so I removed our single dependency on it
It looks like upgrading the controller-gen package amended all the CRDs too - I can revert this if we don't want to touch them?
Checklist
To Do