Closed GitarPlayer closed 12 months ago
Looks good to me!
It might be worth adding a page to the docs for running under openshift? Or adding a section to an existing page with the extra config required π
Looks good to me!
It might be worth adding a page to the docs for running under openshift? Or adding a section to an existing page with the extra config required π
Found the DOC src now, will do it. Done with the DOC and the changelog
I pulled this branch and built it just to make sure any kubebuilder-generated files get updated. I did find one that was missed (i.e. config/rbac/role.yaml
). Can you please run make build
locally and make sure that file gets committed?
Once that's done, i'm happy to merge. Thanks for the contribution :)
Sorry I was out of office for a week. My bad I added the make build
changes.
@GitarPlayer : this PR needs its commits all signed and i can merge. Thanks!
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
π¦ GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Why did this PR have 545 commits and old ones in it?
@GitarPlayer : this PR needs its commits all signed and i can merge. Thanks!
Can you point me out how to sign all my previous commits without making a git mess?
Why did this PR have 545 commits and old ones in it?
christian_bucheli@hotmail.com I tried signing my old commits but I ended up creating a mess. I am not sure what the correct procedure is to sign all my old commits.
@GitarPlayer : this PR needs its commits all signed and i can merge. Thanks!
Can you point me out how to sign all my previous commits without making a git mess?
Why did this PR have 545 commits and old ones in it?
christian_bucheli@hotmail.com I tried signing my old commits but I ended up creating a mess. I am not sure what the correct procedure is to sign all my old commits.
The issue is that you have a bunch of old commits the PR that are triggering an alert because of some secrets that aren't secrets.
@GitarPlayer : this PR needs its commits all signed and i can merge. Thanks!
Can you point me out how to sign all my previous commits without making a git mess?
Why did this PR have 545 commits and old ones in it?
christian_bucheli@hotmail.com I tried signing my old commits but I ended up creating a mess. I am not sure what the correct procedure is to sign all my old commits.
The issue is that you have a bunch of old commits the PR that are triggering an alert because of some secrets that aren't secrets.
This is related to the last three commits where I tried to sign all my commits. If I revert them / remove them from the history, this should be fixed. But do you know the easiest way to sign old commits done by me?
Hmm - i'm not sure how all of these commits got added, but I don't think we want to rewrite that much of the git history by merging. My recommendation would be to correct the commits on this branch or close this PR and raise another with only the signed commit(s) you want to contribute. Sorry for all the trouble for an otherwise simple contribution...
As far as signing old commits, i've found this helpful in the past: https://superuser.com/questions/397149/can-you-gpg-sign-old-commits
I'll often just squash all of my commits into 1 and make sure the one is signed. The easiest thing to do in this case might just be opening a new PR and cherry-pick your changes.
I'd love access to this compatibility feature this week, is there anything I can do to help this move forward?
I'd love access to this compatibility feature this week, is there anything I can do to help this move forward?
Fix the PR, as it is broken (500+ commits). And resolve the conflict.
I'd love access to this compatibility feature this week, is there anything I can do to help this move forward?
I will simply create a new fork and create a new PR and sign all my commits. This is easier than fixing this mess I've created.
I'd love access to this compatibility feature this week, is there anything I can do to help this move forward?
I opened a new PR that is clean and has its commits signed: https://github.com/konpyutaika/nifikop/pull/292
What's in this PR?
Why?
As it is NifiKop does not run on OpenShift without custom day 2 modifications
Additional context
I checked the install on OpenShift
Checklist
To Do