add ability to set metadata on PVCs nifikop creates

konpyutaika / nifikop

The NiFiKop NiFi Kubernetes operator makes it easy to run Apache NiFi on Kubernetes. Apache NiFI is a free, open-source solution that support powerful and scalable directed graphs of data routing, transformation, and system mediation logic.

https://konpyutaika.github.io/nifikop/

Apache License 2.0

125 stars 42 forks source link

add ability to set metadata on PVCs nifikop creates #269

Closed mh013370 closed 1 year ago

mh013370 commented 1 year ago

Q	A
Bug fix?	no
New feature?	yes
API breaks?	no
Deprecations?	no
Related tickets	fixes #267
License	Apache 2.0

What's in this PR?

Adds the ability to attach labels and annotations to PVCs that nifikop creates.

Why?

To attach additional context to the object.

Checklist

[x] Implementation tested
[x] Error handling code meets the guideline
[x] Logging code meets the guideline
[x] User guide and development docs updated (if needed)
[x] Append changelog with changes

mh013370 commented 1 year ago

@juldrixx : quick review? 🙂

Carverook commented 1 year ago

Hello, when can we expect a version with this fix? We really need a new version)

mh013370 commented 1 year ago

@juldrixx : Thoughts on cutting a v1.2.0 release?

pranavarnav2 commented 1 year ago

@juldrixx we would love to get this feature as well, please do release a new version :) Thanks!