Update 1_quick_start.md

fbarchetta commented 10 months ago

A small change in the zookeeper installation that made me loose a couple of days :-)

Q	A
Bug fix?	no	yes
New feature?	no	yes
API breaks?	no	yes
Deprecations?	no	yes
Related tickets	fixes #X, partially #Y, mentioned in #Z
License	Apache 2.0

What's in this PR?

There is a missing parameter in the installation of zookeeper that prevents the initialization of the related container in the nifiCluster later in the procedure.

Why?

Inizialization of the nifiCluster fails because unable to find the zookeeper service in its namespace

Additional context

Checklist

[x] Implementation tested
[ ] Error handling code meets the guideline
[ ] Logging code meets the guideline
[ ] User guide and development docs updated (if needed)
[ ] Append changelog with changes

To Do

[ ] If the PR is not complete but you want to discuss the approach, list what remains to be done here

juldrixx commented 10 months ago

I'm not sure about this change, because according to Helm's documentation (and from my experience), to specify the namespace during an installation or other command, you need to add --namespace <namespace>.

Which version of Helm, are you using?

fbarchetta commented 10 months ago

I'm not sure about this change, because according to Helm's documentation (and from my experience), to specify the namespace during an installation or other command, you need to add --namespace <namespace>.

Which version of Helm, are you using?

Ok I could improperly have taken the "set namespace" from the nifikop installation command as example and it didn't hurt. But we still need to add -namespace . Please let me know if I have to make another commit or if you change that.

konpyutaika / nifikop