konpyutaika / nifikop

The NiFiKop NiFi Kubernetes operator makes it easy to run Apache NiFi on Kubernetes. Apache NiFI is a free, open-source solution that support powerful and scalable directed graphs of data routing, transformation, and system mediation logic.
https://konpyutaika.github.io/nifikop/
Apache License 2.0
123 stars 40 forks source link

Add golangci linter to project #328

Closed umarhussain15 closed 7 months ago

umarhussain15 commented 7 months ago
Q A
Bug fix? no yes
New feature? no yes
API breaks? no yes
Deprecations? no yes
Related tickets
License Apache 2.0

What's in this PR?

This PR adds the configuration for golangci-lint into the repository and also configures the Makefile to use the linter with lint and fmt options. The CircleCI config is also updated to use the linter everytime, currently it is configured to only output issues in linting without failing with exit code 1 i.e. it calls make lint-warn

Links

Checklist

To Do

mh013370 commented 7 months ago

i'll go ahead and merge. risk is low since it's just CI changes.