search

konpyutaika / nifikop

The NiFiKop NiFi Kubernetes operator makes it easy to run Apache NiFi on Kubernetes. Apache NiFI is a free, open-source solution that support powerful and scalable directed graphs of data routing, transformation, and system mediation logic.
https://konpyutaika.github.io/nifikop/
Apache License 2.0
123 stars 40 forks source link

Apply changes from `glonagci-lint run --fix` & `make fmt` to fix some linting issues #329

Closed umarhussain15 closed 7 months ago

umarhussain15 commented 7 months ago
Q A
Bug fix? no yes
New feature? no yes
API breaks? no yes
Deprecations? no yes
Related tickets
License Apache 2.0

What's in this PR?

This PR add linting fixes which were generated by golangci-lint run --fix. This will serve as a base to start fixing other linting issues which were reported by the linter. It also apply fixes generated by make fmt.

Additional context

These changes can be reproduced by checking out master branch and then running golangci run --fix & make fmt

mh013370 commented 7 months ago

Reviewing...

mh013370 commented 7 months ago

Is this PR meant to totally resolve the lint errors or just sort the majority of changes needed?

https://app.circleci.com/pipelines/github/konpyutaika/nifikop/1141/workflows/fc320e97-3ed5-4fc1-9afc-110c98596db1/jobs/2927

umarhussain15 commented 7 months ago

@mh013370 This PR only applies to changes which glonagci-lint run --fix applies. For other reported issues, we need to manually make the changes.

mh013370 commented 7 months ago

Looks like there are a couple of conflicts after a recent merge. If you fix, i'm happy to merge 😄