konpyutaika / nifikop

The NiFiKop NiFi Kubernetes operator makes it easy to run Apache NiFi on Kubernetes. Apache NiFI is a free, open-source solution that support powerful and scalable directed graphs of data routing, transformation, and system mediation logic.
https://konpyutaika.github.io/nifikop/
Apache License 2.0
122 stars 40 forks source link

Update login_identity_providers.xml template for 2.0.0-M1 #354

Closed juldrixx closed 5 months ago

juldrixx commented 5 months ago
Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets partial #360
License Apache 2.0

What's in this PR?

Update of the login_identity_providers.xml template, to match the one in 2.0.0-M1. Changed:

<property name="Identity Strategy">{{.LdapConfiguration.IdentityStrategy}}</property>
<property name="Identity Strategy">{{or .LdapConfiguration.IdentityStrategy "USE_DN"}}</property>

to

<property name="Identity Strategy">{{or .LdapConfiguration.IdentityStrategy "USE_DN"}}</property>

Why?

<property name="Identity Strategy">{{.LdapConfiguration.IdentityStrategy}}</property> removed because it doesn't make sense to have it when you have <property name="Identity Strategy">{{or .LdapConfiguration.IdentityStrategy "USE_DN"}}</property>. Because if .LdapConfiguration.IdentityStrategy is empty, you will have USE_DN otherwise you will have the value of .LdapConfiguration.IdentityStrategy.

Checklist

juldrixx commented 5 months ago

This PR can me merged no impact for older version of NiFi.