search

konpyutaika / nifikop

The NiFiKop NiFi Kubernetes operator makes it easy to run Apache NiFi on Kubernetes. Apache NiFI is a free, open-source solution that support powerful and scalable directed graphs of data routing, transformation, and system mediation logic.
https://konpyutaika.github.io/nifikop/
Apache License 2.0
122 stars 40 forks source link

Update zookeeper.properties template for 2.0.0-M1 #356

Open juldrixx opened 5 months ago

juldrixx commented 5 months ago
Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets Partial #360
License Apache 2.0

What's in this PR?

Update of the zookeeper.properties template, to match the one in 2.0.0-M1.

Checklist

juldrixx commented 5 months ago

I don't know if the change server.1=nifi has an impact. I tested but I have no error.

mh013370 commented 5 months ago

I don't know if the change server.1=nifi has an impact. I tested but I have no error.

It's only used for embedded zookeeper, so I don't think we'd see it in Kubernetes. I think it's probably okay. Anyone using this would need to override it to include each nifi node name anyway, so i don't think there's a risk. This can be merged with no risk.

juldrixx commented 5 months ago

@mh013370 I made a change to not use the template if not needed can you recheck?

mh013370 commented 5 months ago

@mh013370 I made a change to not use the template if not needed can you recheck?

Should we just remove the zookeeper properties template here like we removed the logback template in #353 ?