Expose nifi pod readiness and liveness probes in nifi-cluster helm chart - Githubissues

konpyutaika / nifikop

The NiFiKop NiFi Kubernetes operator makes it easy to run Apache NiFi on Kubernetes. Apache NiFI is a free, open-source solution that support powerful and scalable directed graphs of data routing, transformation, and system mediation logic.

https://konpyutaika.github.io/nifikop/

Apache License 2.0

122 stars 40 forks source link

Expose nifi pod readiness and liveness probes in nifi-cluster helm chart #364

Closed mh013370 closed 5 months ago

mh013370 commented 5 months ago

Q	A
Bug fix?	no
New feature?	yes
API breaks?	no
Deprecations?	no
Related tickets	-
License	Apache 2.0

What's in this PR?

Adds the existing NifiCluster.Spec.Pod.ReadinessProbe and NifiCluster.Spec.Pod.LivenessProbe configuration to the nifi-cluster helm chart.

Why?

This was overlooked when the chart was created.

Checklist

[x] Implementation tested
[x] Error handling code meets the guideline
[x] Logging code meets the guideline
[x] User guide and development docs updated (if needed)
[x] Append changelog with changes

juldrixx commented 5 months ago

I think it's good to merge. Just need to resolve the conflicts. right? @mh013370

mh013370 commented 5 months ago

I think it's good to merge. Just need to resolve the conflicts. right? @mh013370

Agree. I will resolve merge conflicts.