search

konpyutaika / nifikop

The NiFiKop NiFi Kubernetes operator makes it easy to run Apache NiFi on Kubernetes. Apache NiFI is a free, open-source solution that support powerful and scalable directed graphs of data routing, transformation, and system mediation logic.
https://konpyutaika.github.io/nifikop/
Apache License 2.0
122 stars 40 forks source link

Migrate to kubebuilder v4 #366

Closed mh013370 closed 4 months ago

mh013370 commented 5 months ago
Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets fixes #365
License Apache 2.0

What's in this PR?

Migrates the operator to KubeBuilder go/v4 and operator-sdk v1.33.0, applying all appropriate migrations in the process. The migration process required re-scaffolding the entire API and all controllers in order to regenerate the PROJECT configuration, but the actual specs & controller code was copied forward. Regardless, care should be taken in reviewing this to ensure that i did not incidentally leave something out.

I updated the Makefile and all generated Kustomize configuration to match the latest in KubeBuilder. From this point, only minor updates should be required.

Primary changes:

Note Merging this will necessitate updating your locally installed operator-sdk to v1.33.0.

Why?

KubeBuilder go/v4 is now stable and go/v3 will be end-of-lifed and removed.

Checklist

mh013370 commented 5 months ago

Before taking an in-depth look and testing it, I think that the version of Operator SDK is mentionned in the documention (not sure for Kubebuilder itself), so it must be updated accordingly.

Yeah, so basically upgrading to operador-sdk v1.33.0 is just migrating to kubebuilder go/v4:

https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.33.0/

juldrixx commented 5 months ago

Before taking an in-depth look and testing it, I think that the version of Operator SDK is mentionned in the documention (not sure for Kubebuilder itself), so it must be updated accordingly.

Yeah, so basically upgrading to operador-sdk v1.33.0 is just migrating to kubebuilder go/v4:

https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.33.0/

I was thinking of NiFiKop documentation 😄

mh013370 commented 5 months ago

ng of NiFiKop document

Before taking an in-depth look and testing it, I think that the version of Operator SDK is mentionned in the documention (not sure for Kubebuilder itself), so it must be updated accordingly.

Yeah, so basically upgrading to operador-sdk v1.33.0 is just migrating to kubebuilder go/v4: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.33.0/

I was thinking of NiFiKop documentation 😄

You're right it is. Updated :)