search

konpyutaika / nifikop

The NiFiKop NiFi Kubernetes operator makes it easy to run Apache NiFi on Kubernetes. Apache NiFI is a free, open-source solution that support powerful and scalable directed graphs of data routing, transformation, and system mediation logic.
https://konpyutaika.github.io/nifikop/
Apache License 2.0
122 stars 40 forks source link

Add parameter context secret update detection #367

Closed juldrixx closed 5 months ago

juldrixx commented 5 months ago
Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

The operator will look into the ManagedFields of the Secret to retrieve the Time of the operations and extract the latest to compare it to the one stored in its Status to detect the updates.

Why?

The operator needs to be able to update sensitive parameter but as Nifi doesn't return their value, the operator needs to detect the update of secret to trigger an update of the corresponding parameter.

Additional context

Checklist

juldrixx commented 5 months ago

I prefer this solution to the one implemented in PR 309, it does not require a new Controller and can be easly implemented for the other resources that needs it.

mh013370 commented 5 months ago

instead of recommending 10 changes, i'll just let you change lastest to latest everywhere 🙂