search

konpyutaika / nifikop

The NiFiKop NiFi Kubernetes operator makes it easy to run Apache NiFi on Kubernetes. Apache NiFI is a free, open-source solution that support powerful and scalable directed graphs of data routing, transformation, and system mediation logic.
https://konpyutaika.github.io/nifikop/
Apache License 2.0
122 stars 39 forks source link

adds security context for pod and its containers #393

Closed mheers closed 1 month ago

mheers commented 4 months ago
Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

Adds security context for pod and its containers.

Why?

To make nifi cluster pods compatible with e.g. kyverno we need to implement a few basic security measures like SecurityContext.

Checklist

TimMilton commented 2 months ago

We need this too. Thanks.

mheers commented 2 months ago

@mh013370 thanks for your review. Could you have a look again?

Carverook commented 2 months ago

We are really looking forward to this PR. Thanks

mh013370 commented 2 months ago

Please update the CHANGELOG, following the existing convention to include your new feature.

mheers commented 2 months ago

updated the CHANGELOG

mh013370 commented 2 months ago

Sorry one more thing I overlooked! Can you please add these new options to the docs?

https://github.com/konpyutaika/nifikop/blob/master/site/docs/5_references/1_nifi_cluster/3_node_config.md

Then i should be good to merge.

mheers commented 2 months ago

Added the docs.

mheers commented 2 months ago

Docs and CHANGELOG should now be corrected.

mh013370 commented 2 months ago

This LGTM now. Just some CHANGELOG conflicts to resolve :) Thank you for this contribution!