Upgrade nigoapi 0.1.0 - Githubissues

konpyutaika / nifikop

The NiFiKop NiFi Kubernetes operator makes it easy to run Apache NiFi on Kubernetes. Apache NiFI is a free, open-source solution that support powerful and scalable directed graphs of data routing, transformation, and system mediation logic.

https://konpyutaika.github.io/nifikop/

Apache License 2.0

122 stars 39 forks source link

Upgrade nigoapi 0.1.0 #422

Closed juldrixx closed 2 months ago

juldrixx commented 2 months ago

Q	A
Bug fix?	no
New feature?	yes
API breaks?	no
Deprecations?	yes
Related tickets	-
License	Apache 2.0

What's in this PR?

Upgrade of NiGoApi from v0.0.10 to v0.1.0.

Why?

To use the latest API from NiFi 2.0.0-M2.

Checklist

[X] Implementation tested
[X] Error handling code meets the guideline
[X] Logging code meets the guideline
[X] User guide and development docs updated (if needed)
[x] Append changelog with changes

juldrixx commented 2 months ago

@mh013370 Should I remove MaximumEventDrivenThreadCount from v1 CRD or just do it like that?

mh013370 commented 2 months ago

@mh013370 Should I remove MaximumEventDrivenThreadCount from v1 CRD or just do it like that?

Removing it is a breaking change, but we could document that from nifikop v1.9.0+ it has no effect and will be removed in later CRD versions.

mh013370 commented 2 months ago

Is this update compatible with NiFi 1.x NiFi deployments? Or is this PR staged for 2.0?

juldrixx commented 2 months ago

Is this update compatible with NiFi 1.x NiFi deployments? Or is this PR staged for 2.0?

Older version than 1.18 won't fully work. I tested in 1.16 and 1.17 and the operator can't create the registry client so it can't deploy dataflow from it but it can do the rest. And in >=1.18, it works fine. I can create user, group, parameter context, registry client, dataflow. I updated the documention to reflect it.

This was to be expected, as version 1.23 of the api ended up working with version 2.0.0-M2.