konrad-kruczynski / elfsharp

Pure managed C# library for reading ELF, UImage, Mach-O binaries.
https://elfsharp.it
Other
151 stars 56 forks source link

ELFSharp NetStandard Package includes netstandard .dlls #39

Closed Evmaus-MS closed 6 years ago

Evmaus-MS commented 6 years ago

Hey:

It looks like due to an issue with NuGetizer (https://github.com/NuGet/Home/issues/6270), the entire netstandard set of libraries is included in the NuGet package. This isn't an issue if you're consuming the library via .NET Core, but it will cause numerous build conflicts with the standard libraries if you try to consume the library in .NET 4.6.1 (which should be possible).

It should be possible to build the NuGet package from the CSProj file without NuGetizer via dotnet pack ELFSharp.csproj (see: https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-pack?tabs=netcore2x), which seems to avoid including all of the dependencies and removes the dependency on a nonstandard tool, and seems to correctly version/set authors/etc.

--Everett Maus

konrad-kruczynski commented 6 years ago

Very good point. I didn't notice that the package weights about 3MB which should be suspicious on its own. However, I have just tried using dotnet pack and the result is somewhat smaller (1.9MB), but still contains a lot of libraries. Is it the result you expected?

Evmaus-MS commented 6 years ago

Not quite--I'd expect the NuGet to just contain ELFSharp.dll.

I just double checked--you have to remove the NuGetizer reference completely to get the NuGet package with just the .dll.

konrad-kruczynski commented 6 years ago

Turns out that I didn't really understand your comment with NuGetizer. Thanks for the comment, I've just uploaded fixed package (version 1.1.1).

Evmaus-MS commented 6 years ago

Awesome--works great now with Net 4.6.1 (as well as .Net Core).

konrad-kruczynski commented 6 years ago

Exactly.