MachO: Added stream support and ability to continue parsing when exceptions found

konrad-kruczynski / elfsharp

Pure managed C# library for reading ELF, UImage, Mach-O binaries.

https://elfsharp.it

Other

151 stars 56 forks source link

MachO: Added stream support and ability to continue parsing when exceptions found #44

Closed kweinmeister closed 2 years ago

kweinmeister commented 5 years ago

Additional Stream interface provided, for more ways to interact with ELFsharp beyond files directly.
Option to not throw exceptions and store them in an Exceptions array. This enables parsing as much information as possible out of files that have invalid structures, but may still be executable.
Additional unit test added to check Exceptions array. All existing unit tests pass.

konrad-kruczynski commented 5 years ago

Thanks for the PR. I'll try to look at it on Sunday.

konrad-kruczynski commented 5 years ago

Unfortunately I did not manage to do it on Sunday, but I still remember about the PR and will check it ;) From the quick remarks I can put here now: what do you think about adding a test for some malformed MachO binary that will trigger an exception (or rather: trigger it internally but parse what could be parsed).

kweinmeister commented 5 years ago

That is a good idea @konrad-kruczynski, I will add a test for a malformed binary.

konrad-kruczynski commented 5 years ago

@kweinmeister Hi, what's the current status?

kweinmeister commented 5 years ago

Sorry for the delay -- I haven't had time to add the additional unit test. Will try to look into this later.

konrad-kruczynski commented 4 years ago

Ok :)

konrad-kruczynski commented 2 years ago

I'm afraid I'll be closing this PR soon.