search

konrad-kruczynski / elfsharp

Pure managed C# library for reading ELF, UImage, Mach-O binaries.
https://elfsharp.it
Other
151 stars 56 forks source link

Adds Dynamic Section Parsing #46

Closed Evmaus-MS closed 4 years ago

Evmaus-MS commented 5 years ago

This PR adds basic parsing for the .dynamic section, and some simple tests.

Let me know what you think! I did try to largely keep to the repository's conventions for things (but this code was written a while ago, I might've missed something).

This is to cover: https://github.com/konrad-kruczynski/elfsharp/issues/43

konrad-kruczynski commented 5 years ago

First of all thank you for the PR, this is definitely necessary functionality. As you expected, I have a few remarks regarding code style and I'll leave comments within the diff. Apologise for such a long time to have a response but I promise to get back to the PR (after fixes) much faster :)

konrad-kruczynski commented 5 years ago

Hi @Evmaus-MS , I understand that sometimes finding a necessary amount of time can be very hard (and I am a very good example of such a problem) but I am just checking if you plan to review my suggestions.

evmaus commented 5 years ago

Hey:

Sorry, I changed employers shortly after I submitted this, and had to make sure I could still make contributions here under a new OSS policy. I'll try to tackle the feedback in the next few weeks now that I've figured out that it's OK.

konrad-kruczynski commented 4 years ago

Hi, any news about the status?

ConnorChristie commented 4 years ago

I can open a PR with the comments addressed as I am also in need of this functionality

konrad-kruczynski commented 4 years ago

@ConnorChristie that would be great!

konrad-kruczynski commented 4 years ago

Since this was effectively continued in #53 I can now close this PR.