build on macOS CLI and Rider

konrad-kruczynski / elfsharp

Pure managed C# library for reading ELF, UImage, Mach-O binaries.

https://elfsharp.it

Other

150 stars 56 forks source link

Closed bruno-garcia closed 4 years ago

bruno-garcia commented 4 years ago

A couple extra things:

Enabled C# 8
Deleted the second solution (so IDE/ dotnet cli know which one to load automatically). Only solution with tests is available now.
Added ReferenceAssemblies to build .NET 4.5 on macOS with .NET Core

konrad-kruczynski commented 4 years ago

Hi Bruno, I've just had a look at the code and given only one minor remark.

bruno-garcia commented 4 years ago

@konrad-kruczynski Thanks for your review. I've made the change you've requested. Is there anything else that needs changing?

konrad-kruczynski commented 4 years ago

It's fine now, thanks!