Add dynamic section parsing [continuation of #46]

konrad-kruczynski / elfsharp

Pure managed C# library for reading ELF, UImage, Mach-O binaries.

https://elfsharp.it

Other

150 stars 56 forks source link

Add dynamic section parsing [continuation of #46] #53

Closed ConnorChristie closed 4 years ago

ConnorChristie commented 4 years ago

This is a continuation of PR #46

~~I will soon work on testing this against some actual binaries but for now, this just cleaned up the code to match the review comments made in the other PR.~~

I have tested this on an actual binary and it works as expected.

ConnorChristie commented 4 years ago

@konrad-kruczynski This is ready for review

konrad-kruczynski commented 4 years ago

Hi @ConnorChristie . It looks very well on the first glance, but first I have to resolve GitLFS-related problems. I didn't know that there is a transfer quota and each clone takes from that quota, so that I am not even able to clone the repository now. I have to find a different way to store test binaries then. Maybe a second, normal repository linked via a submodule. Perchance you have an idea?

konrad-kruczynski commented 4 years ago

I decided to end up with creating a separate repository for binaries, accessible via a submodule. I'll perform this transformation after your changes are merged. There is only one thing to be done before I can merge it. Please bump informational and package version in ELFSharp.csproj to 2.3.0.