search

konrad11901 / Inspiron7373-macOS

Running macOS Catalina on Dell Inspiron 7373 (2-in-1)
2 stars 2 forks source link

ACPI good practices #1

Open konrad11901 opened 4 years ago

konrad11901 commented 4 years ago

The current ACPI patching I'm using isn't compliant with, let's say, good practices.

For example, according to OpenCore documentation, it is suggested to:

Avoid patching _OSI to support a higher level of feature sets unless absolutely required. Commonly this enables a number of hacks on APTIO firmwares, which result in the need to add more patches. Modern firmwares generally do not need it at all, and those that do are fine with much smaller patches.

and

Avoid renaming devices with ACPI patches. This may fail or perform improper renaming of unrelated devices (e.g. EC and EC0), be unnecessary, or even fail to rename devices in select tables.

baddles commented 4 years ago

Avoid renaming devices with ACPI patches. This may fail or perform improper renaming of unrelated devices (e.g. EC and EC0), be unnecessary, or even fail to rename devices in select tables.

https://github.com/acidanthera/bugtracker/issues/743 There is a discussion on how ACPI patches should be implemented. The way I'd do it is to implement the original SSDT-EC-USBX and leave it be. If you uncomment the top part and rename it to ECDV it will freezes the system because ECDV controls battery EC.

konrad11901 commented 4 years ago

Hmm, I've just tested it and everything works properly. I'll add the SSDT-EC-USBX and remove the ECDV->EC patch shortly. Thanks a lot!

I'd also work on the OSI->XOSI patch removal in the future. Currently, removing it breaks the touchpad, touchscreen and brightness buttons (the last one is easy to fix though).

baddles commented 4 years ago

Could be that _OSI in the DSDT controls how renaming works, or I might be wrong. I'm actually fine with F13 and F14 being Fn+S and Fn+B respectively for the brightness buttons, and touchpad/touchscreens work.