search

konrad1977 / emacs

My emacs configuration
64 stars 9 forks source link

ivy-posframe face in kanagawa theme causing unreadable UI #4

Closed HeyParkerJ closed 1 year ago

HeyParkerJ commented 2 years ago

Hi, firstly thank you so much for making this theme! It's the first one I've seen in a few years that got me really excited to have discovered and use it!

I did run into one hiccup during usage that I have finally figured out enough to write to you about it, and that's that my ivy-posframe would be completely unreadable on initial load of Emacs, due to what I believe is the ivy-posframe setting here. I'll attach some screenshots.

One thing I do not understand, is that by running M-x load-theme with kanagawa after Emacs finished loading would fix this issue, so I'm not entirely sure if this is an issue with the theme itself, or my own setup.

This is the frame on initial load Screen Shot 2022-09-06 at 12 35 54 PM

This is after reloading kanagawa with M-x load-theme Screen Shot 2022-09-06 at 12 36 02 PM

This is after commenting out L307 linked above. Screen Shot 2022-09-06 at 12 54 16 PM

If this isn't replicatable, obviously feel free to close this issue as it must be something on my end, but I wanted to at least document this in case I'm not the only one to run into the problem.

Thank you again! Truly do love this theme (enough for me to learn a bit about theming and how I could fix this issue!)

konrad1977 commented 2 years ago

I need to look into this. I am not using ivy anymore (consult/vertico) now. But I have to make sure it works for all completion frameworks. Thanks for reporting.

konrad1977 commented 2 years ago

The reason it works after you loading the theme again with load-theme is that posframe doesnt load correctly, it must be done during startup (or atleast I had the same problem with teams and pos frames).

konrad1977 commented 2 years ago

@HeyParkerJ I updated the theme let me know if it works.

I added catppuccin-mocha/frappe/machiato themes which you might like to.