from_dict: check if data is required data_class already (created by defaut_factory)

konradhalas / dacite

Simple creation of data classes from dictionaries.

MIT License

1.72k stars 107 forks source link

Closed rominf closed 5 years ago

rominf commented 5 years ago

Any thoughts?

konradhalas commented 5 years ago

Hi @rominf I will go through your PR's letter this week, sorry for a delay.

konradhalas commented 5 years ago

@rominf thank you for your contribution! Of course it's a bug, I fixed it in a little different way (similar to _inner_from_dict_for_union function - https://github.com/konradhalas/dacite/commit/89613810018431e782ec5dffc82962b81ea0b553) but it's based on your solution.

Once again thank you! 👍