search

konradjk / loftee

MIT License
174 stars 55 forks source link

Use catdir for gerp_bigwig path #99

Open dvg-p4 opened 1 year ago

dvg-p4 commented 1 year ago

Closes #95

should probably test this more thoroughly

konradjk commented 11 months ago

Thanks! Does this need a dependency? Looks like it's in File::Spec - is that guaranteed to be loaded by VEP/LOFTEE?

dvg-p4 commented 11 months ago

To be quite honest, I don't know perl--I'm copy-coding from elsewhere in the file, e.g. here: https://github.com/konradjk/loftee/blob/a46b502a68c812c8ae0c5a5721c0603fe81cae8d/LoF.pm#L86-L87

konradjk commented 11 months ago

🤦 good call. it's been a while. it looks like there's actually a catfile just below that that's meant for files that might be better