search

konradkalemba / korona.ws

🗺 Coronavirus interactive map of Poland
https://korona.ws
73 stars 29 forks source link

Fix Contributors component #18

Closed mhajder closed 4 years ago

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/konradkalemba/korona-ws/dtkrdc38l ✅ Preview: https://korona-ws-git-fork-mhajder-fix-contributorscomponent.konradkalemba.now.sh

konradkalemba commented 4 years ago

@mhajder Does it prevent the error you mentioned in #15?

mhajder commented 4 years ago

@mhajder Does it prevent the error you mentioned in #15?

Yes. You could still add a conditional statement that doesn't display these elements: https://github.com/konradkalemba/korona.ws/blob/647a891ef2dc7963b0a6b3b6cbac9d929e765f24/src/components/Layout/Desktop.jsx#L114-L115

Also after rewriting the layout, the #12 Pull Request did not work.

konradkalemba commented 4 years ago

@mhajder Hmm, you're right. But in your's pull request preview deployment custom scrollbars work, at least for me.

konradkalemba commented 4 years ago

Ahh, it was before the layout changes were implemented. Never mind.