konradkalemba / korona.ws

🗺 Coronavirus interactive map of Poland
https://korona.ws
73 stars 29 forks source link

Latest cases #3

Closed chybaDapi closed 4 years ago

chybaDapi commented 4 years ago

Hello, It would be nice to have latest cases listing next to cities chart tab. Something like in the picture, latest cases on the top. Thanks to that, it would be easier to find new cases, because now you need to remember all numbers and old cases locations to notice a new one, or check every pin on the map to find a case with a latest date. image

I wanted to prepare a pull request with suggested changes, but I'm not able to run the app on my local env due to following error:

Installations: Missing App configuration value: "projectId" (installations/missing-app-config-values).

konradkalemba commented 4 years ago

Hi, thanks for the issue.

The feature you suggested is currently being worked on.

Regarding error you bumped into while trying to run the app on your own. It is a problem with Firebase connection, which needs to be configured beforehand. I will try write a tutorial how to do so.

Have you ever used Firebase? If so you can create a database there by yourself and I can send you a JSON file of cases. I will also check if I can generate public credentials to give read access to the database the app is using.

konradkalemba commented 4 years ago

Implemented in the latest release.

konradkalemba commented 4 years ago

@chybaDapi I updated the repository with contributing guide if you want to contribute.

Sekhmet commented 4 years ago

I see that latest cases on the same date are not sorted properly because time of the day is not stored. Would it be possible to sort them by the time the case was entered to Firebase?

konradkalemba commented 4 years ago

@Sekhmet Hmm, you're right - I didn't notice it. I don't know if Firebase stores times of the data modifications. Maybe I can just reverse cases array from the database, which is stored in chronological order and there won't be a need to sort it again. Therefore we will avoid this bug.

konradkalemba commented 4 years ago

Should be fixed now.