search

konradknitter / homebridge-philips-tv-ambilight

Apache License 2.0
16 stars 5 forks source link

Ambilight settings #2

Open Shaft405 opened 3 years ago

Shaft405 commented 3 years ago

Hello Konrad

Thanks for your great work! Here is a feature request to solve what I find to be a very annoying problem.

Describe The Problem:

The TV's Ambilight configuration is lost after switching Ambilight off. With Ambilight style set on TV to follow the video, when Ambilight is switched off from the plugin and then back on, the Ambilight style is no longer follow video. It goes to a static color.

To Reproduce:

Step 1: Set Ambilight style to "Follow video" on TV Step 2: Switch off Ambilight with plugin Step 3: Switch Ambilight back on with plugin

Logs:

Results of above steps using requests to API : ambilight/current-configuration

Step 1: {"styleName":"FOLLOW_VIDEO","isExpert":false,"menuSetting":"STANDARD"} Step 2: {"styleName":"OFF","isExpert":false} Step 3: {"styleName":"FOLLOW_COLOR","isExpert":false,"menuSetting":"HOT_LAVA"}

Desired Behavior:

Have the plugin able to set the Ambilight default settings or restore them like they were on the TV before Ambilight was switched off.

Proposed Evolution:

Define Ambilight preferred settings in the plugin's configuration and apply to ambilight/currentconfiguration for styleName and menuSetting when Ambilight is switched on.

Idea for Future Plugin Config

{ "accessory": "PhilipsTVAmbilight", "name": "Philips TV Ambilight", "ip": "xxx.xxx.xxx.xxx", "macAddress": "xx:xx:xx:xx:xx:xx", "ambilightStyle": "FOLLOW_VIDEO", "styleSetting": "STANDARD",
}

Environment:

konradknitter commented 3 years ago

hey, thanks for proposal! I'm not satisfied yet with this plug-in also, so I will for sure tackle this problem over next couple of days

leviotte commented 3 years ago

Thnx for making thisone! AWESOME!!

ktsi commented 3 years ago

Hi all! Merry Christmas! Any news on more ambilight control? I would love being able to turn on "follow video" mode through Siri. Still it is already the best plugin (also the TV one) for philips android TVs so far. Thanks!!

konradknitter commented 3 years ago

I have few moments now to implement new functions, and I'm looking for a ways to implement controlling modes within lightbulb - did you seen any plugins supporting switch of modes?

leviotte commented 3 years ago

I haven’t with the lightbulb. You’re doing a good job with the selection in apps though. I think if you put in a sensor for the app like: youtube, plex, spotify, ... the plugin can show the actual current app playing.

Met Sportieve groeten

Levi Otte Coach - Voedingsadvies en begeleiding 💻 Website 💻 Facebook 📱 Instagram 📱 0475/34.44.02 💌 leviotte@icloud.com

Op 30 dec. 2020 om 13:29 heeft Konrad Knitter notifications@github.com het volgende geschreven:

 I have few moments now to implement new functions, and I'm looking for a ways to implement controlling modes within lightbulb - did you seen any plugins supporting switch of modes?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

konradknitter commented 3 years ago

Thanks for reply, I worry that main accessory needs to have ActiveIdentifier to use InputSources. Lightbulb doesn't have it accordingly to Homebridge API.

I asked this also on Discord, in case will not find any confirmed answer I will try using Input Sources.