search

konradpabjan / move-labeled-or-milestoned-issue

MIT License
27 stars 23 forks source link

multi label / cols #6

Open thbl opened 4 years ago

thbl commented 4 years ago

Is it possible to add multi labels / cols ? Or do i need to make a new work flow for each label ?

konradpabjan commented 4 years ago

Unfortunately right now you can only specify a single label 🤔 though it should be very simple to add support for multiple labels.

Pretty much the found boolean just needs to be set to true very early on. https://github.com/konradpabjan/move-labeled-or-milestoned-issue/blob/6ad2dc3ffc9175c8cdeaf659e954b3b757ee2c12/index.js#L36

LeonardAukea commented 3 years ago

This would be a good extension

pkoch commented 3 years ago

@konradpabjan How open to a PR would you be? Are there any guidelines it would need to follow?

konradpabjan commented 3 years ago

I would be open to accepting a PR 😃

My last tag was v2.0 a long long time ago so with any new changes I would just bump it up to v3.0.

No major guidelines unfortunately and I never had time to create a contributor doc. This was one my first actions I wrote and I regretfully wish I did it with typescript instead of pure JS but 🤷‍♂️ Best practices have changed significantly. Also I would like to get rid of node_modules since it's best practice to use webpack with something like NCC (we do this for all GitHub first party actions).

My only ask if submitting a PR would be to try not to add any new NPM packages (so that the node_modules folder is not modified). It should be possible without any new packages and a few modifications in index.js should suffice

pkoch commented 3 years ago

I'm an actions n00b, sorry in advance is the question is not great.

I agree wirh you that the crux of it will be toggling found, but I'd like to talk about how to represent the condition. My use case is to only trigger the action is 2 specific labels being there. Should I maybe turn that field into a comma separated one?

I can also see this evolving to a binary expression system (A & B | !C), but i feel like that's a "next level" improvement.

We'll need to make this a major bump, I think, since it'll change the semantics of the field

marina-chibizova commented 2 years ago

@pkoch have you found a solution for this?

My use case is to only trigger the action is 2 specific labels being there.

My use case is similar, I need to identify the project and column based on the combination of labels

pkoch commented 2 years ago

Sorry, no movement here. :/

marina-chibizova commented 2 years ago

thanks for respond