konradrenner / kolabnotes-android

Note taking app with integrated Kolab sync
GNU Lesser General Public License v3.0
68 stars 17 forks source link

Kolab Notizen v3.2.0 - Disabling the "Enable Rich Text Editor" feature, making this application suddenly stop #197

Closed ammarraisafti closed 5 years ago

ammarraisafti commented 5 years ago

Actual behaviour

It should, after disabling the "EnableRichTextEditor" feature. This application still works well.

Expected behaviour

After successfully disabling the "EnableRichTextEditor" feature in the application / general settings section. I tried adding "New Notebook", then accessing the edit icon. And after I successfully entered the edit icon, I tried to return to the previous menu. Unfortunately, this application suddenly stopped.

Step to reproduce

Information

Recording of the bug

https://youtu.be/d9JK0CkZtfU

konradrenner commented 5 years ago

Wow, thank you for the the detailed report. I will soon have a look at it

konradrenner commented 5 years ago

I can confirm the issue. The bug occurs if rich text editing is disabled an the back or print function is used.

There is no check for this 2 functions if rich text editing is disabled (!Utils.getUseRicheditor(activity)).

NullPointer when print is used: at org.kore.kolabnotes.android.fragment.DetailFragment.printNote (DetailFragment.java:1563)

NullPointer when back is used: at org.kore.kolabnotes.android.fragment.DetailFragment.onBackPressed (DetailFragment.java:1494)

ammarraisafti commented 5 years ago

Thank you for confirming this problem. Speaking of code, I don't understand that. I hope that this problem solving can be done. Because I really enjoy this application, and have invited several other users to use this application, also giving the best rating for application.

konradrenner commented 5 years ago

I am glad that the app is useful for you!

It should be no problem to solve the problem, but please be patient, I am short on my time at the moment

ammarraisafti commented 5 years ago

Yeah, okay. I will be happy to wait.

Pada tanggal Sel, 2 Jul 2019 00.46, Konrad Renner notifications@github.com menulis:

I am glad that the app is useful for you!

It should be no problem to solve the problem, but please be patient, I am short on my time at the moment

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/konradrenner/kolabnotes-android/issues/197?email_source=notifications&email_token=AI7ZO4UX5UWVOQUFFACW5HDP5I7GHA5CNFSM4H4G7KM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY63MJQ#issuecomment-507360806, or mute the thread https://github.com/notifications/unsubscribe-auth/AI7ZO4R7UHSI2Z7BQLCQHU3P5I7GHANCNFSM4H4G7KMQ .

konradrenner commented 5 years ago

will be fixed in 3.2.1

konradrenner commented 5 years ago

published new release, will be available soon