konradsz / igrep

Interactive Grep
MIT License
663 stars 17 forks source link

Update Scoop instructions #50

Closed rashil2000 closed 1 year ago

rashil2000 commented 1 year ago

I have raised a PR to add igrep in Scoop's Main (default) bucket - https://github.com/ScoopInstaller/Main/pull/5156

This will allow users to directly install igrep without adding/managing a custom bucket - and the manifest update will also happen automatically.

However there's a small hiccup - there seems to be a type in the current Windows release asset's name - the .zip part is present twice. This is why tests are failing in the PR linked above. Could you please fix/rename that?

konradsz commented 1 year ago

Good catch, I fixed the name of the Windows package.

konradsz commented 1 year ago

Correct me if I am wrong, but don't we have a deadlock here? I should wait with updating instructions until igrep is added to Scoop's main bucket, but you mentioned there it is blocked by https://github.com/konradsz/igrep/pull/50 :)

rashil2000 commented 1 year ago

I have merged the linked PR