search

konsolas / AAC-Issues

AAC Issue Tracker.
32 stars 15 forks source link

Movement falsepositive - AAC doesn't handle relative X Y Z teleport flags properly? #2241

Closed makindotcc closed 3 years ago

makindotcc commented 3 years ago

Issue description

Sending packet PacketPlayOutPosition (https://wiki.vg/index.php?title=Protocol&oldid=16541#Player_Position_And_Look_.28clientbound.29) with flags 

    Sets.newHashSet(
                EnumPlayerTeleportFlags.X, EnumPlayerTeleportFlags.Y, EnumPlayerTeleportFlags.Z,
                EnumPlayerTeleportFlags.X_ROT, EnumPlayerTeleportFlags.Y_ROT)
    }

will cause movement false positive. My theory is that aac doesn't handle these flags correctly. AAC is ignoring fact that relative X Y Z teleport doesn't reset vanilla client motion as it does with absolute X Y Z teleportation.

Video with debugs: https://youtu.be/uhIPY0bU6Xc

Core information

Server version: 1.16.5 tuinity

AAC version: 5.0.14

ProtocolLib version: 4.6.0-SNAPSHOT-b492

Configuration

default

konsolas commented 3 years ago

duplicate of #2094