search

konsolas / AAC-Issues

AAC Issue Tracker.
32 stars 15 forks source link

1.17 client seems to send additional position packet on interact #2304

Open Janmm14 opened 2 years ago

Janmm14 commented 2 years ago

Issue description

1.17(.1 only?): Judging from a debug log, it looks like an extea move packet with the same location (diff 0) is sent when you interact with an item. This causes setbacks in-air as the client is detected as not following gravity rules.

https://discord.com/channels/248161240038375435/262588738939387904/882960464173236224

I did not check it myself

Core information

Server version: 1.17.1 purpur

AAC version: 5.2.0

ProtocolLib version:

Plugin list:

Special environment information

ViaVersion version: no

ProtocolSupport version: no

ViaBackwards version: no

BungeeCord plugins: ??

Configuration

https://discord.com/channels/248161240038375435/262588738939387904/882723079292342273

claytyne commented 2 years ago

I can help with the ?, thats me from discord lol

ProtocolLib Version: 4.7.1-SNAPSHOT-b531

Plugin list: image image image

And BungeeCord is not enabled

And this is the entire config just in case: (replaced by gist by janmm14) https://gist.github.com/Janmm14/5d5184b4aa0fd71099a19d7c5a8f43b3

fabianmakila commented 2 years ago

Can confirm. Happens on Paper 1.17.1-251 with only AAC and latest Protocollib dev build(#531) installed. I'm using default AAC config and experiencing said setback when running and right-clicking with an item.

ghost commented 2 years ago

me to

claytyne commented 2 years ago

Is this going to be fixed soon? This is a premium plugin after all and I expect some level of care from the dev

Janmm14 commented 2 years ago

Is this going to be fixed soon? This is a premium plugin after all and I expect some level of care from the dev

Technically all updates of spigotmc premium plugins are a free bonus.

konsoals is currently taking a break from aac development for an unknown amount of months. He himself does not know when he will work on it again.

claytyne commented 2 years ago

fine

andrewkm commented 2 years ago

Is this going to be fixed soon? This is a premium plugin after all and I expect some level of care from the dev

The plugin is officially deserted, don't bother with it lol. Use a different solution.

claytyne commented 2 years ago

its fucking idiotic, the dev probably made so much money off it and just left

andrewkm commented 2 years ago

its fucking idiotic, the dev probably made so much money off it and just left

Too selfish to even release the code or get others to help update the project. Lol. It's hilarious how people attempt to defend this shit too.

claytyne commented 2 years ago

And how much money was that like 20GBP or something? fucking scam

Janmm14 commented 2 years ago

And how much money was that like 20GBP or something? fucking scam

It is only a scam if you are unable to read the spigotmc guidelines before you buy.

All updates of spigotmc premium plugins are a free bonus. What you pay for is to download the plugin once as-is and access to eventual future plugin updates.

claytyne commented 2 years ago

But when you pay for a plugin its expected to get some sort of communication from the dev right? you said konsolas is taking a break for an unknown amount of months, dude, I am getting drafted & studying for my finals and still able to log into discord and type a message

andrewkm commented 2 years ago

And how much money was that like 20GBP or something? fucking scam

It is only a scam if you are unable to read the spigotmc guidelines before you buy.

All updates of spigotmc premium plugins are a free bonus. What you pay for is to download the plugin once as-is and access to eventual future plugin updates.

Reiterating the same bullshit and fine print doesn't make it right. You're not even attempting to be virtuous anymore, just plain stupid. Stop replying lol.

As it stands there is a completely broken non functional product being SOLD. At the very least what's being sold is expected to work for new buyers. Nothing to do with updates kid, grow up.

Janmm14 commented 2 years ago

And how much money was that like 20GBP or something? fucking scam

It is only a scam if you are unable to read the spigotmc guidelines before you buy. All updates of spigotmc premium plugins are a free bonus. What you pay for is to download the plugin once as-is and access to eventual future plugin updates.

Reiterating the same bullshit and fine print doesn't make it right. You're not even attempting to be virtuous anymore, just plain stupid. Stop replying lol.

As it stands there is a completely broken non functional product being SOLD. At the very least what's being sold is expected to work for new buyers. Nothing to do with updates kid, grow up.

@andrewkm

  1. You did not buy the plugin recently.
  2. Buyers do get a functional product.
  3. I am not reiterating the same bullshit. You are continuing to ignore the clear rules set by spigotmc.

This is not the first time you are acting like an entitled brat. Grow up.

In the servercrasher issue you tell me: Oh no this is a random jar file and advice people to not use it. You ignore my 100% valid arguments. With that attitude, go switch to an open-source anticheat then please.

PS: Seems like your devs had no luck in reverse-engineering AAC.

andrewkm commented 2 years ago

And how much money was that like 20GBP or something? fucking scam

It is only a scam if you are unable to read the spigotmc guidelines before you buy.

All updates of spigotmc premium plugins are a free bonus. What you pay for is to download the plugin once as-is and access to eventual future plugin updates.

Reiterating the same bullshit and fine print doesn't make it right. You're not even attempting to be virtuous anymore, just plain stupid. Stop replying lol.

As it stands there is a completely broken non functional product being SOLD. At the very least what's being sold is expected to work for new buyers. Nothing to do with updates kid, grow up.

@andrewkm

  1. You did not buy the plugin recently.

  2. Buyers do get a functional product.

  3. I am not reiterating the same bullshit. You are continuing to ignore the clear rules set by spigotmc.

This is not the first time you are acting like an entitled brat. Grow up.

In the servercrasher issue you tell me: Oh no this is a random jar file and advice people to not use it. You ignore my 100% valid arguments. With that attitude, go switch to an open-source anticheat then please.

PS: Seems like your devs had no luck in reverse-engineering AAC.

Oh we're long running our own custom solution, doesn't mean I won't continue to call out this projects bullshit when it comes to new buyers.

I stopped using this trash ages ago. Try again lol. My purchase date has nothing to do with the fact you're continuing to scam new buyers without as much as stating on the purchase page that the plug-in is currently inactive.

Straight up fraud. Your response is delusional.

Janmm14 commented 2 years ago

I stopped using this trash ages ago. Try again lol. My purchase date has nothing to do with the fact you're continuing to scam new buyers without as much as stating on the purchase page that the plug-in is currently inactive.

Straight up fraud. Your response is delusional.

Should not be hard for new buyers to see the last updated-date or read one of the recent 1-star-reviews. Your definition of fraud is wrong and it is still no scam.

Also I cannot even edit the spigotmc page of AAC.

andrewkm commented 2 years ago

I stopped using this trash ages ago. Try again lol. My purchase date has nothing to do with the fact you're continuing to scam new buyers without as much as stating on the purchase page that the plug-in is currently inactive.

Straight up fraud.

Your response is delusional.

Should not be hard for new buyers to see the last updated-date or read one of the recent 1-star-reviews.

Your definition of fraud is wrong and it is still no scam.

Also I cannot even edit the spigotmc page of AAC.

You keep telling yourself that.

claytyne commented 2 years ago

yo lmao just found out this has been a problem for a long time now for some reason: https://www.youtube.com/watch?v=Yp7nKI_04JE

Janmm14 commented 2 years ago

yo lmao just found out this has been a problem for a long time now for some reason: https://www.youtube.com/watch?v=Yp7nKI_04JE

That could be a different issue actually.

claytyne commented 2 years ago

yo lmao just found out this has been a problem for a long time now for some reason: https://www.youtube.com/watch?v=Yp7nKI_04JE

That could be a different issue actually.

So is it going to be fixed soon?

andrewkm commented 2 years ago

yo lmao just found out this has been a problem for a long time now for some reason:

https://www.youtube.com/watch?v=Yp7nKI_04JE

That could be a different issue actually.

So is it going to be fixed soon?

No, project is abandoned.

Timmi6790 commented 2 years ago

The issue is not limited to 1.17.1, the client sends an additional movement packet on every item usage since 1.17.

(You can find the code snippet in net.minecraft.client.multiplayer.MultiPlayerGameMode if you use the mojang mappings.) Capture

IAmOarcle commented 2 years ago

how to solve this problem?

amnoah commented 2 years ago

This "bug" is actually a bug fix from Mojang. When placing water buckets, there could be issues regarding the player's location which would cause the bucket to not place and the client not be informed that it didn't work. As a response., the player sends their location when they place water... and any other time they press right-click. It has actually been in the game since 1.16, but Konsolas successfully made it so AAC ignored position packets when this happens. However, AAC is currently abandoned and it likely cannot properly tell that 1.17 and 1.18 are above 1.16 (as client versions are not reported to the anticheat that simply) so these extra positions aren't ignored like 1.16. The only way to fix this is to have Konsolas update AAC.

Timmi6790 commented 2 years ago

This "bug" is actually a bug fix from Mojang. When placing water buckets, there could be issues regarding the player's location which would cause the bucket to not place and the client not be informed that it didn't work. As a response., the player sends their location when they place water... and any other time they press right-click. It has actually been in the game since 1.16, but Konsolas successfully made it so AAC ignored position packets when this happens. However, AAC is currently abandoned and it likely cannot properly tell that 1.17 and 1.18 are above 1.16 (as client versions are not reported to the anticheat that simply) so these extra positions aren't ignored like 1.16. The only way to fix this is to have Konsolas update AAC.

I checked the 1.16 and 1.16.5 versions of the game and I can't find what you described. The useItem method does not send an additional movement packet and nowhere else is the movement packed being sent that could achieve what you described. Capture