search

konsolas / AAC-Issues

AAC Issue Tracker.
32 stars 15 forks source link

[Suggestion] custom AAC listener priority #780

Closed re-ovo closed 7 years ago

re-ovo commented 7 years ago

I think AAC can add Listener-priority in some checks such as FastBreak/FastPlace AAC always use MONITOR priority, it will cause compatibility problem in some times. for example: A mini-game plugin listen BlockBreakEvent in Normal priority,and it saves data to HashMap about player has breaked the block,but if AAC cancel the event in MONITOR priority....it will cause some blocks cant break

I suggest add listener pripority setting in FastBreak FastPlace Nuker check

Janmm14 commented 7 years ago

AAC currently doesn't use monitor for its listeners as far as I know. It might be that the fastbreak revamp accidetally made konsolas choose the wrong priority but usually aac listens on lowest or lower

Janmm14 commented 7 years ago

If you think its on monitor, I am going to mark this as a bug, as it should be on lower or lowest.

There is no support in craftbukkit's event systen for adjustable listener priorities and I don't see a real reason to build around that.

konsolas commented 7 years ago

Listener priority for fastbreak is LOWEST, listener priority for fastplace is HIGHEST & ignoreCancelled (to improve compatibility with world protection plugins).