Falling through the blocks after fly detection + Fly FP [the most important bug of AAC]

[Toshka17]

Unfortunately this is not fixed. And it happens very often. Without AAC, this never happens. All the players on my server are just furious, it's been two months now. This is unbearably hampering the play.

Latest AAC, Latest Spigot 1.12.1 Lastest ViaVersion + Latest ViaBackwards It also happens on Spigot 1.8.8 + Latest ViaVersion

If necessary, I can attach logs, videos, screenshots. I have a lot of this. In the falling into the blocks, the Fly check is to blame. Because in logs verbose it is fly check.

[RaynLegends]

It's ridiculous, it's literally made AAC unusable.

I can confirm that it "works" both using 1.8.8 + ViaVersion and 1.12.1 + ProtocolSupport, using the latest version of AAC (but it is present since May at least).

[Toshka17]

Video: https://youtu.be/DW1q_ZV72bQ Log: https://pastebin.com/NTnhVjFe [08:32:24 INFO]: Plugins (2): AAC, ProtocolLib Spigot 1.12.1

[ItzSomebody]

Any version of AAC + ProtocolSupport can be expected to have problems do to ProtocolSupport doing something funny to the packets.

@Toshka17 there is no such thing as Spigot 1.8.9 lol. @Toshka17 @RaynLegends what versions of ProtocolLib are you using for 1.12.1 and 1.8.8?

[Toshka17]

This occurs even without Protocolsupport or viaversion. Look at my previous post: only AAC and ProtocolLib

[Toshka17]

Recommended 4.3.0 ProtocolLib (build #373) @ItzSomebody You funny from a typo?

[ItzSomebody]

Some other people are having the same bug, hmm.

[ludgart]

I have the same problem.

Latest AAC Spigot 1.8.9 ProtocolLib v4.2.1 ViaVersion: 1.1.1

[CeIebrimbor]

This bug is now known by hackers and is being used maliciously to get sucked under blocks and become invincible. As reported in #914.

https://www.youtube.com/watch?v=EJ8nUEEHvaM&t=78s

It's more of an exploit, but adding the "Bypass" label.

[konsolas]

@Toshka17 are you able to provide a minimal, verifiable example? For example, a spigot server with only AAC and ProtocolLib, where /tp player causes the bug to occur consistently?

[Toshka17]

@konsolas but I already did it, read my previous post on Aug 28, 2017...

Video: https://youtu.be/DW1q_ZV72bQ Log: https://pastebin.com/NTnhVjFe [08:32:24 INFO]: Plugins (2): AAC, ProtocolLib Spigot 1.12.1

[konsolas]

I'm going to take a moment to rebuild 1.12.1 then, since I'm not having that issue

[Toshka17]

I will now record one more video.

[konsolas]

Fresh 1.12.1 build (since 5 minutes ago) with AAC 3.3.1 and ProtocolLib 4.3.0:

I ran this command in the console multiple times:

which points to a grounded location, seen here:

Each teleport to the location was successful, and I wasn't stuck under the ground, regardless of elevation or location before the teleport.

[Toshka17]

You have to teleport a long distance to get it

[konsolas]

How long?

[Toshka17]

5 thousand blocks are enough

[Toshka17]

https://youtu.be/IEUepn3kGCQ

[CeIebrimbor]

I was under the impression that the Fly setback was the main cause. Which just so happened to occur with most long range teleports

[Toshka17]

The most important problem is not in teleportation. Teleports only give false positives of fly check. The main problem is that fly check, when AAC try to act on the player, teleports him through the blocks.

If you find any other false positives of fly check, players will also teleport through the blocks.

[konsolas]

teleporting myself between -3000, 4, -3000 and 3000, 4, 3000

not only was I not sucked into any blocks, I didn't even get any fly violations

[konsolas]

@Toshka17 could you rebuild spigot 1.12.1, maybe that's the cause.

[konsolas]

Just added some generic code to prevent fly from teleporting into blocks, but I can't test it.

[Toshka17]

Okey, this does not happen with a clean spigot. But it still happens with viaversion.

[konsolas]

I thought your test case was just AAC and ProtocolLib?

[Toshka17]

Yes, it was so, but I pumped the last spigot and tried to repeat it many times - I did not succeed.

[Toshka17]

Just added some generic code to prevent fly from teleporting into blocks, but I can't test it.

Can I somehow test this right away?

[konsolas]

Sure; do you have discord? Join the AAC server and send me a DM

[Nvaros]

Just tried to do it again on GommeHD (QSG) and it seems to be fixed. I wasn't able to get sucked into a block.

[Toshka17]

But this does not mean that it does not exist