konstantinmuenster / gatsby-theme-portfolio-minimal

A Gatsby Theme to create modern one-page portfolios with a clean yet expressive design.
MIT License
161 stars 91 forks source link

feat: allow custom image fit property #37

Closed Xstoudi closed 1 year ago

Xstoudi commented 1 year ago

Meh: image

Yeah: image

Not really sure if it's the best way to achieve it.

Xstoudi commented 1 year ago

I'm not really sure about what to write in the README for that ahah, I'm open to suggestions.

konstantinmuenster commented 1 year ago

I'm not really sure about what to write in the README for that ahah, I'm open to suggestions.

hm, true. There is currently no section that really fits. You could instead add the new prop to all section boilerplates files you find in here. Just want to make sure that new users know this prop exists.

So, for example, for the contact.example.json:

{
    "name": "",
    "email": "",
    "description": "",
    "image": {
        "src": "",
        "alt": "",
        "objectFit": ""
    },
    "socialProfiles": {
        "from": [""],
        "showIcons": true
    }
}
Xstoudi commented 1 year ago

Make sense, I did it, let me know if anything else is needed.

konstantinmuenster commented 1 year ago

Thank you very much for contributing! :)

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 4.5.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: