konstantinmuenster / gatsby-theme-portfolio-minimal

A Gatsby Theme to create modern one-page portfolios with a clean yet expressive design.
MIT License
157 stars 89 forks source link

I Want To Change Background Color of Footer? #51

Closed awais-mustafa closed 4 months ago

awais-mustafa commented 9 months ago

I changed in node module footer file, in gatsby-theme-portfolio-minimal. And its working on local server but, when i deployed this local server website to Vercel. Then its download the node modules from server, so its replaced my customization, so any solution because i think its very hard-coded, correct me if i am wrong?

sdelorme commented 9 months ago

@awais-mustafa Rather than attempting to change any of the package contents, you should be attempting to shadow since you are using a theme.

With that said, I noticed that there's some inline-styling here that might be making it impossible to override with just shadowing the CSS source file. @konstantinmuenster am I right? Seems like you'd have to also re-write the source Footer component itself?

Screenshot 2023-12-27 at 1 38 58 PM
konstantinmuenster commented 9 months ago

@sdelorme True! Due to the inline styles, you'd need to shadow the Footer component too (given that you want to adapt the inline styles too). But usually, the shadowing should work fine for both, CSS and JS files.