konstaui / konsta

Mobile UI components made with Tailwind CSS
https://konstaui.com
MIT License
3.55k stars 131 forks source link

TabbarLink doesn't extend Link #123

Closed 0x62 closed 1 year ago

0x62 commented 1 year ago

Check that this is really a bug

Reproduction link

None

Bug description

In the docs, it says that TabbarLink extends Link, and has all the same properties, however this is not correct.

For example, this vue-router snippet from the Link docs doesn't work with TabbarLink:

<k-link :link-props="{to: '/about'}" component="router-link">
  About
</k-link>

The below will throw a vue-router error about to being undefined:

<k-tabbar-link :link-props="{to: '/about'}" component="router-link">
      <template #label> About </template>
</k-tabbar-link>

Expected Behavior

TabbarLink extends Link

Actual Behavior

It does not. TabbarLink component props is missing a spread of Link props.

https://github.com/konstaui/konsta/blob/master/src/vue/components/TabbarLink.vue#L39

Konsta UI version

1.0.2

Platform/Target and Browser Versions

Chrome

Validations

Would you like to open a PR for this bug?