Use 'tabIndex' instead of 'tabindex' - Githubissues

konstaui / konsta

Mobile UI components made with Tailwind CSS

https://konstaui.com

MIT License

3.3k stars 119 forks source link

Use 'tabIndex' instead of 'tabindex' #169

Closed CesGalaxy closed 8 months ago

CesGalaxy commented 8 months ago

Check that this is really a bug

[X] I confirm

Reproduction link

https://github.com/konstaui/konsta/blob/b2bfcf0fb1cdeb85d80bebb7350b937644783f99/src/react/components/Link.jsx#L100

Bug description

The Link component uses tabindex instead of tabIndex property

https://github.com/konstaui/konsta/blob/b2bfcf0fb1cdeb85d80bebb7350b937644783f99/src/react/components/Link.jsx#L100

Expected Behavior

Use tabIndex="0"

Actual Behavior

Uses tabindex="0"

Konsta UI version

3.0.1

Platform/Target and Browser Versions

Windows 11 & Chrome 116

Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Konsta UI issue and not a framework-specific issue

Would you like to open a PR for this bug?

[x] I'm willing to open a PR

jkhaui commented 8 months ago

Ha what timing, this has been bugging me for a few days too now and I literally just visited this repo to open a PR fixing it: https://github.com/konstaui/konsta/pull/170

@nolimits4web, thanks for this awesome lib, when you get a chance is it possible to also merge in https://github.com/konstaui/konsta/pull/167? If you need, I can make a new issue for it.

Cheers!