konstaui / konsta

Mobile UI components made with Tailwind CSS
https://konstaui.com
MIT License
3.52k stars 131 forks source link

Support type on Button #82

Closed will-ks closed 2 years ago

will-ks commented 2 years ago

Clear and concise description of the problem

As a developer using Konsta UI I want the Button component to support the same type property as the List Button supports so that it can be used correctly in forms.

Suggested solution

Copy List Button's type implementation to Button

Alternative

No response

Additional context

No response

Validations

Would you like to open a PR for this feature?

nolimits4web commented 2 years ago

It is already supported

will-ks commented 2 years ago

Hi @nolimits4web, thanks for the response, I just went ahead and tried it and it indeed correctly supported! The issue then is a TypeScript issue, as it's not included in the types definition for Button (at least in React).

Screenshot 2022-09-16 at 11 52 11

I can live with that though ;) Thanks!