konstructio / gitops-catalog

kubefirst gitops catalog repository
24 stars 25 forks source link

refactor(kubernetes-dashboard): move override to separate values.yaml file #179

Open muse-sisay opened 3 weeks ago

muse-sisay commented 3 weeks ago

Description

Related Issue(s)

How to test

Follow steps in Contributing.md to deploy the app.

muse-sisay commented 3 days ago

Hey @CristhianF7

Indeed, ArgoCD raises an error if two Applications are managing the same resource. (i.e the resource has the same name, destination cluster and type ). In this PR though, the service-account and role binding are created in downstream cluster. Even though in multiple installation of the app the resource have the same name they are not the same resource.

There is going to be a problem if a user installs two copies of the app in the same downstream cluster. Luckily that is not a feature we support and don't have to worry about, for now.

bonus point : Because the resources are name the same across different downstream accounts, if we ever write script/automation or ask user to ran some sort of command (eg. kubectl -n kubernetes-dashboard create token dashboard-user), they don't have to modify the resource name to match the cluster they are running against.

Muse