Don't let users install applications from the GitOps catalog that won't work on k3d

konstructio / gitops-catalog

kubefirst gitops catalog repository

21 stars 21 forks source link

Don't let users install applications from the GitOps catalog that won't work on k3d #36

Closed tomekz closed 11 months ago

tomekz commented 11 months ago

Linked issue

added k3d field to index.yaml
- if false the application can't be installed on a k3d cluster.
- If omitted, we assume it can be installed

fharper commented 11 months ago

Sorry @tomekz, I was out last week, and the team was focussing on the v2.3 release for this week, so they missed your PR.

I'll review it today.

tomekz commented 11 months ago

Thanks @fharper I've signed off all the commits also as I see it is required I did open one side quest tiny PR for console, not related to the issue. Pls have a look

fharper commented 11 months ago

@tomekz can you sign your commit please? In the meantime, I'll review the PRs for this.

I read somewhere you did, but maybe you didn't push your change as they are not signed. If you're successful, you'll see the verified badge next to them, like this.

CleanShot 2023-10-23 at 15 41 14@2x

fharper commented 11 months ago

Here are the instructions https://docs.github.com/en/authentication/managing-commit-signature-verification