search

konstructio / gitops-template

upstream template for your open source gitops repository
MIT License
67 stars 56 forks source link

fix: sync gcp-github metaphor image template values with aws-github #549

Closed cameronraysmith closed 1 year ago

cameronraysmith commented 1 year ago

This might be something to consider addressing in association with the issue raised by https://github.com/kubefirst/kubefirst/pull/1774.

In https://github.com/kubefirst/gitops-template/commit/cafa37eb633713ce3d38b4aaf82e915d418f0997, the aws-github metaphor chart values were transitioned from

metaphor:
  image:
    repository: ghcr.io/<GITHUB_OWNER>/metaphor

to 

metaphor:
  image:
    repository: <CONTAINER_REGISTRY_URL>/metaphor

which ensured the package name was appended and provided the opportunity to support artifact registries other than ghcr. The gcp provider didn't receive this update, perhaps because --gar support was not an initial goal, but it might be useful to abstract the FQIN in preparation for support of --gar by analogy to --ecr unless the plan is to create separate subdirectories for every provider-registry pairing.